makssent opened a new issue, #40289: URL: https://github.com/apache/shardingsphere/issues/40289
### Before reporting a bug - [x] I have searched open and closed [GitHub issues](https://github.com/apache/shardingsphere/issues). - [x] I have read the [ShardingSphere documentation](https://shardingsphere.apache.org/document/current/en/overview). ### ShardingSphere version master, commit [`01446d4fad4`](https://github.com/apache/shardingsphere/commit/01446d4fad48450e7fc3eb3b3631b25d6bf411df) ### ShardingSphere project ShardingSphere-Proxy ### Expected behavior The proxy should execute [`FIRST`](https://github.com/FirebirdSQL/firebird/blob/v5.0.4/src/dsql/parse.y#L6024-L6028) and [`SKIP`](https://github.com/FirebirdSQL/firebird/blob/v5.0.4/src/dsql/parse.y#L6031-L6035) with an expression in parentheses as the Firebird server does. ### Actual behavior The proxy rejects each of these statements with a syntax error. The same statements were executed directly on the Firebird server and through the proxy: | Steps | Firebird server | Proxy | | --- | --- | --- | | `SELECT FIRST (1 + 1) ID FROM T_PLAIN WHERE ID = -1` | Success, no rows | Error [`isc_dsql_error`](https://github.com/FirebirdSQL/firebird/blob/v5.0.4/src/include/firebird/impl/msg/jrd.h#L250) "Dynamic SQL Error; You have an error in your SQL syntax: no viable alternative at input '+1)'" | | `SELECT FIRST 1 SKIP (0 + 1) ID FROM T_PLAIN WHERE ID = -1` | Success, no rows | Error [`isc_dsql_error`](https://github.com/FirebirdSQL/firebird/blob/v5.0.4/src/include/firebird/impl/msg/jrd.h#L250) "Dynamic SQL Error; You have an error in your SQL syntax: no viable alternative at input '+1)'" | So through the proxy an application cannot give the row limit of [`FIRST`](https://github.com/FirebirdSQL/firebird/blob/v5.0.4/src/dsql/parse.y#L6024-L6028) and [`SKIP`](https://github.com/FirebirdSQL/firebird/blob/v5.0.4/src/dsql/parse.y#L6031-L6035) as an expression. ### Reason analysis - The rules [`firstValue`](https://github.com/apache/shardingsphere/blob/01446d4fad48450e7fc3eb3b3631b25d6bf411df/parser/sql/engine/dialect/firebird/src/main/antlr4/imports/firebird/DMLStatement.g4#L92-L94) and [`skipValue`](https://github.com/apache/shardingsphere/blob/01446d4fad48450e7fc3eb3b3631b25d6bf411df/parser/sql/engine/dialect/firebird/src/main/antlr4/imports/firebird/DMLStatement.g4#L96-L98) of the Firebird grammar of ShardingSphere accept only a number or a parameter marker, optionally in parentheses, not an expression, so the proxy rejects these statements with a syntax error. - [`FirebirdDMLStatementVisitor#visitFirstValue`](https://github.com/apache/shardingsphere/blob/01446d4fad48450e7fc3eb3b3631b25d6bf411df/parser/sql/engine/dialect/firebird/src/main/java/org/apache/shardingsphere/sql/parser/engine/firebird/visitor/statement/type/FirebirdDMLStatementVisitor.java#L355-L364) and [`visitSkipValue`](https://github.com/apache/shardingsphere/blob/01446d4fad48450e7fc3eb3b3631b25d6bf411df/parser/sql/engine/dialect/firebird/src/main/java/org/apache/shardingsphere/sql/parser/engine/firebird/visitor/statement/type/FirebirdDMLStatementVisitor.java#L367-L376) build only a number or a parameter marker (the comment `// TODO Add expression support for firstSkipClause`), although the binder already evaluates [`ExpressionPaginationValueSegment`](https://github.com/apache/shardingsphere/blob/01446d4fad48450e7fc3eb3b3631b25d6bf411df/infra/binder/core/src/main/java/org/apache/shardingsphere/infra/binder/context/segment/select/pagination/PaginationContext.java#L74-L75). ### Steps to reproduce #### Environment - Firebird server 5.0. - Client: Jaybird 6.0.7. #### Steps 1. Create the table on the Firebird server: ```sql CREATE TABLE T_PLAIN (ID INTEGER NOT NULL PRIMARY KEY, NAME VARCHAR(20)); ``` 2. Start ShardingSphere-Proxy with this configuration: ```yaml # global.yaml authority: users: - user: root@% password: root privilege: type: ALL_PERMITTED props: proxy-frontend-database-protocol-type: Firebird ``` ```yaml # database-firebird.yaml databaseName: firebird_db dataSources: ds_0: url: jdbc:firebirdsql://<host>/<database file>?encoding=UTF8 username: <user> password: <password> rules: - !SINGLE tables: - "*.*" ``` 3. Execute the statements from the table under "Actual behavior" through the proxy and directly on the Firebird server, and compare the results. "Example code" runs all of them. ### Example code The statements from the table on Jaybird 6.0.7. The comment above each call shows what it prints against the Firebird server and through the proxy. ```java import java.sql.Connection; import java.sql.DriverManager; import java.sql.ResultSet; import java.sql.ResultSetMetaData; import java.sql.SQLException; import java.sql.Statement; import java.sql.Types; import java.util.ArrayList; import java.util.List; public class FirstSkipExpression { // The proxy; put the URL, user and password of the Firebird server here to compare static final String URL = "jdbc:firebirdsql://<proxy host>:<proxy port>/firebird_db?encoding=UTF8&wireCrypt=DISABLED"; static final String USER = "root"; static final String PASSWORD = "root"; public static void main(final String[] args) throws SQLException { try (Connection connection = DriverManager.getConnection(URL, USER, PASSWORD)) { // Firebird server: "SELECT FIRST (1 + 1) ID FROM T_PLAIN WHERE ID = -1 -> ID INTEGER: no rows"; // proxy: "SELECT FIRST (1 + 1) ID FROM T_PLAIN WHERE ID = -1 -> error: Dynamic SQL Error; You have an error in your SQL syntax: no viable alternative at input '+1)' [SQLState:42000, ISC error code:335544569]" execute(connection, "SELECT FIRST (1 + 1) ID FROM T_PLAIN WHERE ID = -1"); // Firebird server: "SELECT FIRST 1 SKIP (0 + 1) ID FROM T_PLAIN WHERE ID = -1 -> ID INTEGER: no rows"; // proxy: "SELECT FIRST 1 SKIP (0 + 1) ID FROM T_PLAIN WHERE ID = -1 -> error: Dynamic SQL Error; You have an error in your SQL syntax: no viable alternative at input '+1)' [SQLState:42000, ISC error code:335544569]" execute(connection, "SELECT FIRST 1 SKIP (0 + 1) ID FROM T_PLAIN WHERE ID = -1"); } } // Executes the statement and prints the described columns with the rows, the update count or the error static void execute(final Connection connection, final String sql) { try (Statement statement = connection.createStatement()) { if (!statement.execute(sql)) { System.out.println(sql + " -> update count " + statement.getUpdateCount()); return; } try (ResultSet resultSet = statement.getResultSet()) { ResultSetMetaData metaData = resultSet.getMetaData(); List<String> columns = new ArrayList<>(); for (int i = 1; i <= metaData.getColumnCount(); i++) { int type = metaData.getColumnType(i); boolean text = Types.CHAR == type || Types.VARCHAR == type; columns.add(metaData.getColumnLabel(i) + " " + metaData.getColumnTypeName(i) + (text ? "(" + metaData.getPrecision(i) + ")" : "")); } List<String> rows = new ArrayList<>(); while (resultSet.next()) { List<String> values = new ArrayList<>(); for (int i = 1; i <= metaData.getColumnCount(); i++) { values.add(String.valueOf(resultSet.getObject(i))); } rows.add(String.join(", ", values)); } System.out.println(sql + " -> " + String.join(", ", columns) + ": " + (rows.isEmpty() ? "no rows" : String.join("; ", rows))); } } catch (final SQLException ex) { System.out.println(sql + " -> error: " + ex.getMessage()); } } } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
