tristaZero commented on pull request #6359: URL: https://github.com/apache/shardingsphere/pull/6359#issuecomment-660058695
Hi @SirMin Thanks for your feedback. I would like to discuss this feature with you and @terrymanu. Let us light up our minds! `ThreadLocal` is designed for `ShardingSphere` to get specific sharding values from users. But `an average user` will not care about `ThreadLocal ` or not, and he or she just wants to get one instance of `hintManger`. If this function always returns the same one, it is likely to confuse users that `hintManger` is in`Singleton pattern`. Therefore, they might believe that the same `hintManger` will be returned in different threads, though. One important point here is that how we tell users the information that `hintManger` is going to return the same one only in the current thread. That is my opinion about this feature, what do you think? @SirMin @terrymanu ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
