jingshanglu commented on a change in pull request #7619:
URL: https://github.com/apache/shardingsphere/pull/7619#discussion_r495558198
##########
File path:
shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/asserts/statement/dml/impl/InsertStatementAssert.java
##########
@@ -59,6 +61,7 @@ public static void assertIs(final SQLCaseAssertContext
assertContext, final Inse
assertInsertSelectClause(assertContext, actual, expected);
assertOnDuplicateKeyColumns(assertContext, actual, expected);
assertWithClause(assertContext, actual, expected);
+ assertOutputClause(assertContext, actual, expected);
Review comment:
@dongzl @tristaZero @strongduanmu We should discuss aboult parser
test framework,one:first determin db type and then assert; two:assert all
segment include in all db in `InsertStatementAssert.java`,and then decide
whether to assert or not according to DB type.What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
