jingshanglu commented on a change in pull request #7619:
URL: https://github.com/apache/shardingsphere/pull/7619#discussion_r495565885
##########
File path:
shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/asserts/statement/dml/impl/InsertStatementAssert.java
##########
@@ -59,6 +61,7 @@ public static void assertIs(final SQLCaseAssertContext
assertContext, final Inse
assertInsertSelectClause(assertContext, actual, expected);
assertOnDuplicateKeyColumns(assertContext, actual, expected);
assertWithClause(assertContext, actual, expected);
+ assertOutputClause(assertContext, actual, expected);
Review comment:
> @jingshanglu @tristaZero @dongzl Now, the refactor task of `Statement`
just splits different dialect statements, `StatementContext` and
`StatementAssert` are not splitted. When `Statement` is used by
`StatemenContext` and `StatementAssert`, different dialect statements are
processed uniformly through the `StatementHandler` now.
>
> I was wondering if we need to split `StatemenContext` and
`StatementAssert`, since `StatementHandler` seems to handle logic well already.
you mean the two way? decide whether to assert or not according to DB type
in specific function, like some segment only contained by SQLServer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
