menghaoranss commented on a change in pull request #10327:
URL: https://github.com/apache/shardingsphere/pull/10327#discussion_r631674857
##########
File path:
shardingsphere-proxy/shardingsphere-proxy-bootstrap/src/main/java/org/apache/shardingsphere/proxy/initializer/impl/GovernanceBootstrapInitializer.java
##########
@@ -90,13 +90,18 @@ private boolean isEmptyLocalConfiguration(final
YamlProxyServerConfiguration ser
entry ->
swapperEngine.swapToRuleConfigurations(entry.getValue().getRules()), (oldValue,
currentValue) -> oldValue, LinkedHashMap::new));
}
+ private Collection<RuleConfiguration> getGlobalRuleConfigurations(final
Collection<YamlRuleConfiguration> globalRuleConfigs) {
+ return new
YamlRuleConfigurationSwapperEngine().swapToRuleConfigurations(globalRuleConfigs);
+ }
+
private ProxyConfiguration loadProxyConfiguration() {
Collection<String> schemaNames =
governanceFacade.getRegistryCenter().getAllSchemaNames();
Map<String, Map<String, DataSourceParameter>> schemaDataSources =
loadDataSourceParametersMap(schemaNames);
Map<String, Collection<RuleConfiguration>> schemaRules =
loadSchemaRules(schemaNames);
Properties props =
governanceFacade.getRegistryCenter().loadProperties();
// TODO load global rules from reg center
Review comment:
`TODO` should be removed in next PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
