tristaZero commented on a change in pull request #11028:
URL: https://github.com/apache/shardingsphere/pull/11028#discussion_r659504459
##########
File path:
shardingsphere-infra/shardingsphere-infra-context/src/main/java/org/apache/shardingsphere/infra/context/metadata/MetaDataContextsBuilder.java
##########
@@ -94,21 +95,21 @@ public StandardMetaDataContexts build() throws SQLException
{
Collection<RuleConfiguration> ruleConfigs =
schemaRuleConfigs.get(each);
DatabaseType databaseType =
DatabaseTypeRecognizer.getDatabaseType(dataSourceMap.values());
Collection<ShardingSphereRule> rules =
ShardingSphereRulesBuilder.buildSchemaRules(each, ruleConfigs, databaseType,
dataSourceMap);
- Map<Map<String, TableMetaData>, Map<String, TableMetaData>>
tableMetaDataMap = SchemaBuilder.build(new SchemaBuilderMaterials(databaseType,
dataSourceMap, rules, props));
+ TableMetaDatas tableMetaDatas = SchemaBuilder.build(new
SchemaBuilderMaterials(databaseType, dataSourceMap, rules, props));
Review comment:
It is supposed that one actual tableMetadata has a corresponding logic
tableMetaData, isn't it?
Suppose `ShardingSphereSchema` has all the `decorated` tableMetaData, the
`OptimizeContextFactory` will own all the non-`decoreated` tableMetaData, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
