totalo commented on a change in pull request #11028:
URL: https://github.com/apache/shardingsphere/pull/11028#discussion_r661106733



##########
File path: 
shardingsphere-infra/shardingsphere-infra-context/src/main/java/org/apache/shardingsphere/infra/context/metadata/impl/StandardMetaDataContexts.java
##########
@@ -54,23 +55,8 @@
     private final StateContext stateContext;
     
     public StandardMetaDataContexts() {
-        this(new LinkedHashMap<>(), 
-                new ShardingSphereRuleMetaData(Collections.emptyList(), 
Collections.emptyList()), null, new ConfigurationProperties(new Properties()));
-    }
-    
-    /**
-     * todo remove this deprecated constructor.
-     * @deprecated old
-     */
-    @Deprecated
-    public StandardMetaDataContexts(final Map<String, ShardingSphereMetaData> 
metaDataMap, final ShardingSphereRuleMetaData globalRuleMetaData, 
-                                    final ExecutorEngine executorEngine, final 
ConfigurationProperties props) {
-        this.metaDataMap = new LinkedHashMap<>(metaDataMap);
-        this.globalRuleMetaData = globalRuleMetaData;
-        this.executorEngine = executorEngine;
-        optimizeContextFactory = new OptimizeContextFactory(metaDataMap);
-        this.props = props;
-        stateContext = new StateContext();
+        this(new LinkedHashMap<>(), new 
ShardingSphereRuleMetaData(Collections.emptyList(), Collections.emptyList()),
+                null, new ConfigurationProperties(new Properties()), new 
OptimizeContextFactory(new HashMap<>()));

Review comment:
       My oversight. I made the change, but it doesn't seem to have triggered 
the change.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to