guimingyue commented on pull request #10889: URL: https://github.com/apache/shardingsphere/pull/10889#issuecomment-869686853
> @guimingyue If we add a UT for converter, which assertions are expected? > > ```java > assertEquals(2, sqlSelect.getSelectList().size()); > assertNull(sqlSelect.getWhere()); > assertThat(optional.get(), instanceOf(SqlSelect.class)) > ``` > > Do you think these items are enough? > > Could you firstly create a few UT issues for these `converter`, like #10904? We can assign these issues you created to other contributors. These UT asserts are not enough, we should compare the result with Calcite parser result. I will create some ideal UT first. And then create issues to assign to other contributors. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
