RaigorJiang opened a new issue #11247: URL: https://github.com/apache/shardingsphere/issues/11247
### Background Currently, we use [Hikari](https://github.com/brettwooldridge/HikariCP) as the connection pool In `Proxy`, and properties are seted to the connection pool in class `DataSourceConfiguration` by invoke the `setter` method. But in class `DataSourceParameterConverter`, where the props are prepared for Hikari, some keys are not match the Hikari prroperties, such as `maxPoolSize`, `minPoolSize`, `maintenanceIntervalMilliseconds`. ```java private static DataSourceConfiguration createDataSourceConfiguration(final DataSourceParameter dataSourceParameter) { DataSourceConfiguration result = new DataSourceConfiguration(HikariDataSource.class.getName()); result.getProps().put("jdbcUrl", dataSourceParameter.getUrl()); result.getProps().put("username", dataSourceParameter.getUsername()); result.getProps().put("password", dataSourceParameter.getPassword()); result.getProps().put("connectionTimeout", dataSourceParameter.getConnectionTimeoutMilliseconds()); result.getProps().put("idleTimeout", dataSourceParameter.getIdleTimeoutMilliseconds()); result.getProps().put("maxLifetime", dataSourceParameter.getMaxLifetimeMilliseconds()); result.getProps().put("maxPoolSize", dataSourceParameter.getMaxPoolSize()); result.getProps().put("minPoolSize", dataSourceParameter.getMinPoolSize()); result.getProps().put("maintenanceIntervalMilliseconds", dataSourceParameter.getMaintenanceIntervalMilliseconds()); result.getProps().put("readOnly", dataSourceParameter.isReadOnly()); if (null != dataSourceParameter.getCustomPoolProps()) { result.getProps().putAll(new HashMap(dataSourceParameter.getCustomPoolProps())); } return result; } ``` > In Hikari, there is a property `maximumPoolSize` but no `maxPooSize`. So, although `maxPoolSize` is specified to '50' in our configuration, it is actually the default value '10' used. ### Question Is this a defect? Or are there other considerations? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
