RaigorJiang edited a comment on issue #11247:
URL: 
https://github.com/apache/shardingsphere/issues/11247#issuecomment-878886696


   @terrymanu 
   Yes, after investigating parameters of class `HikariConfig` and historical 
code of ShardingSphere, the following information is obtained:
   
   - The parameter corresponding to `maintenanceIntervalMilliseconds` cannot be 
found in Hikari, `maintenanceIntervalMilliseconds`has never been used. 
   - There is no `minPoolSize` parameter in Hikari,  but `minimumIdle` is close 
to it. Hikari's suggestion is not to configure it.
   - `maxPoolSize` should be `maximumPoolSize`.
   
   In summary, I suggest to modify the props name of `maxPoolSize` and 
`maxPoolSize ` (just in DataSourceParameterConverter) and delete 
`maintenanceIntervalMilliseconds `.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to