[GitHub] [shardingsphere] chengh1 commented on a change in pull request #11666: Insert clause not support routing to multiple dataNodes when is not broadcastTable. #11623

Mon, 09 Aug 2021 00:57:27 -0700 


chengh1 commented on a change in pull request #11666:
URL: https://github.com/apache/shardingsphere/pull/11666#discussion_r684984532



##########
File path: 
shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-core/src/main/java/org/apache/shardingsphere/sharding/route/engine/validator/dml/impl/ShardingInsertStatementValidator.java
##########
@@ -97,5 +97,17 @@ public void postValidate(final ShardingRule shardingRule, 
final SQLStatementCont
         if (needCheckDatabaseInstance) {
             Preconditions.checkState(routeContext.isSingleRouting(), "Sharding 
value must same with subquery.");
         }
+        if (routeContext.isSingleRouting()) {

Review comment:
       The integration test module already contains my test scenarios, so I 
don’t need to add a new test case.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to