strongduanmu commented on a change in pull request #11666:
URL: https://github.com/apache/shardingsphere/pull/11666#discussion_r684990713
##########
File path:
shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-core/src/main/java/org/apache/shardingsphere/sharding/route/engine/validator/dml/impl/ShardingInsertStatementValidator.java
##########
@@ -97,5 +97,17 @@ public void postValidate(final ShardingRule shardingRule,
final SQLStatementCont
if (needCheckDatabaseInstance) {
Preconditions.checkState(routeContext.isSingleRouting(), "Sharding
value must same with subquery.");
}
+ if (routeContext.isSingleRouting()) {
Review comment:
> The integration test module already contains my test scenarios, so I
don’t need to add a new test case.
@chengh1 You need add test case in `ShardingInsertStatementValidatorTest`
for this logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
