Technoboy- commented on pull request #1956: URL: https://github.com/apache/shardingsphere-elasticjob/pull/1956#issuecomment-895648028
> > Hi @stanstanwang > > I think returning null is not elegant. How about throw something like `JobConfigurationException`? > > in my usage scenario , there is no check config exists method, so every time before i get the config, i must catch the NullPointerException , this is troublesome, may be mark the method return @nullable or using Optional is also elegant Currently, fit it that not throw NPE is enough. Other further discuss can open a new thread to discuss. @TeslaCN -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
