TeslaCN commented on pull request #1956: URL: https://github.com/apache/shardingsphere-elasticjob/pull/1956#issuecomment-895707160
> > Returning `null` is violate our code of conduct. I think `Optional` may be better. > > Where do this conflict? If conflict, we should also refactor ZookeeperRegistryCenter. Not this API. This API is used by user directly. Maybe the `ZookeeperRegistryCenter` does need to be refactored but not in this issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
