strongduanmu commented on a change in pull request #12280:
URL: https://github.com/apache/shardingsphere/pull/12280#discussion_r708863169
##########
File path:
shardingsphere-distsql-parser/shardingsphere-distsql-parser-engine/src/main/java/org/apache/shardingsphere/distsql/parser/core/advanced/AdvancedDistSQLParser.java
##########
@@ -23,12 +23,14 @@
import org.apache.shardingsphere.sql.parser.api.visitor.ASTNode;
import org.apache.shardingsphere.sql.parser.core.ParseASTNode;
+import java.util.Properties;
+
/**
* SQL parser for advanced dist SQL.
*/
public final class AdvancedDistSQLParser extends
AdvancedDistSQLStatementParser implements SQLParser {
- public AdvancedDistSQLParser(final TokenStream input) {
+ public AdvancedDistSQLParser(final TokenStream input, final Properties
props) {
Review comment:
@tuichenchuxin Can we remove this useless props?
##########
File path:
shardingsphere-sql-parser/shardingsphere-sql-parser-spi/src/main/java/org/apache/shardingsphere/sql/parser/api/parser/SQLParser.java
##########
@@ -24,6 +24,8 @@
*/
public interface SQLParser {
+ String ENABLE_SQL_COMMENT_PARSE = "enable-sql-comment-parse";
Review comment:
@tuichenchuxin Can we replace this constant with
ConfigurationPropertyKey?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
