strongduanmu commented on a change in pull request #12280:
URL: https://github.com/apache/shardingsphere/pull/12280#discussion_r709912184
##########
File path:
shardingsphere-proxy/shardingsphere-proxy-frontend/shardingsphere-proxy-frontend-mysql/src/main/java/org/apache/shardingsphere/proxy/frontend/mysql/command/query/binary/execute/MySQLComStmtExecuteExecutor.java
##########
@@ -68,7 +68,8 @@
public MySQLComStmtExecuteExecutor(final MySQLComStmtExecutePacket packet,
final BackendConnection backendConnection) {
String schemaName = backendConnection.getSchemaName();
ShardingSphereSQLParserEngine sqlStatementParserEngine = new
ShardingSphereSQLParserEngine(DatabaseTypeRegistry.getTrunkDatabaseTypeName(
-
ProxyContext.getInstance().getContextManager().getMetaDataContexts().getMetaData(schemaName).getResource().getDatabaseType()));
+
ProxyContext.getInstance().getContextManager().getMetaDataContexts().getMetaData(schemaName).getResource().getDatabaseType()),
Review comment:
@tuichenchuxin Can we extract param MetaDataContexts?
##########
File path:
shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/SQLParserFactory.java
##########
@@ -45,19 +47,35 @@
* @param sql SQL
* @param lexerClass lexer class
* @param parserClass parser class
+ * @param sqlCommentParseEnabled enable sql comment parse
* @return SQL parser
*/
- public static SQLParser newInstance(final String sql, final Class<?
extends SQLLexer> lexerClass, final Class<? extends SQLParser> parserClass) {
- return createSQLParser(createTokenStream(sql, lexerClass),
parserClass);
+ public static SQLParser newInstance(final String sql, final Class<?
extends SQLLexer> lexerClass, final Class<? extends SQLParser> parserClass,
final boolean sqlCommentParseEnabled) {
+ return createSQLParser(createTokenStream(sql, lexerClass),
parserClass, sqlCommentParseEnabled);
}
@SneakyThrows(ReflectiveOperationException.class)
- private static SQLParser createSQLParser(final TokenStream tokenStream,
final Class<? extends SQLParser> parserClass) {
+ private static SQLParser createSQLParser(final TokenStream tokenStream,
final Class<? extends SQLParser> parserClass, final boolean
sqlCommentParseEnabled) {
SQLParser result =
parserClass.getConstructor(TokenStream.class).newInstance(tokenStream);
+ setEnableSqlCommentParse(result, parserClass, sqlCommentParseEnabled);
((Parser) result).setErrorHandler(new BailErrorStrategy());
return result;
}
+ private static void setEnableSqlCommentParse(final SQLParser result, final
Class<? extends SQLParser> parserClass, final boolean sqlCommentParseEnabled)
Review comment:
@tuichenchuxin Can this method be simplified?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
