justbk2015 commented on a change in pull request #12749:
URL: https://github.com/apache/shardingsphere/pull/12749#discussion_r716204065
##########
File path:
shardingsphere-scaling/shardingsphere-scaling-dialect/shardingsphere-scaling-opengauss/src/main/java/org/apache/shardingsphere/scaling/opengauss/component/OpenGaussScalingSQLBuilder.java
##########
@@ -34,19 +39,31 @@ public OpenGaussScalingSQLBuilder(final Map<String,
Set<String>> shardingColumns
@Override
public String getLeftIdentifierQuoteString() {
- return "\"";
+ return "";
}
@Override
public String getRightIdentifierQuoteString() {
- return "\"";
+ return "";
}
@Override
public String buildInsertSQL(final DataRecord dataRecord) {
return super.buildInsertSQL(dataRecord) + buildConflictSQL();
}
+ @Override
+ public List<Column> extractUpdatedColumns(final Collection<Column>
columns, final DataRecord record) {
+ return new ArrayList(Collections2.filter(columns, column ->
!(column.isPrimaryKey()
+ || isShardingColumn(getShardingColumnsMap(),
record.getTableName(), column.getName()))));
+ }
+
+ private boolean isShardingColumn(final Map<String, Set<String>>
shardingColumnsMap,
+ final String tableName, final String
columnName) {
+ return shardingColumnsMap.containsKey(tableName)
+ && shardingColumnsMap.get(tableName).contains(columnName);
+ }
+
private String buildConflictSQL() {
// there need return ON DUPLICATE KEY UPDATE NOTHING after support
this syntax.
Review comment:
I have report issue:#12328, but nobody reponse.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
