justbk2015 commented on a change in pull request #12749:
URL: https://github.com/apache/shardingsphere/pull/12749#discussion_r716484565



##########
File path: 
shardingsphere-scaling/shardingsphere-scaling-core/src/main/java/org/apache/shardingsphere/scaling/core/common/sqlbuilder/ScalingSQLBuilder.java
##########
@@ -44,6 +47,17 @@
      */
     String buildUpdateSQL(DataRecord dataRecord, Collection<Column> 
conditionColumns);
     
+    /**
+     * Extract need updated columns.
+     *
+     * @param columns the input columns
+     * @param record the input datarecord
+     * @return the filtered columns.
+     */
+    default List<Column> extractUpdatedColumns(Collection<Column> columns, 
DataRecord record) {
+        return new ArrayList<>(RecordUtil.extractUpdatedColumns(record));
+    }

Review comment:
       no, this method will called at AbstractImporter::execteUpdate to filter 
updated field.
   
![image](https://user-images.githubusercontent.com/12265143/134875488-f28f3f69-e7ee-4567-9922-94ca5be527db.png)
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to