justbk2015 commented on a change in pull request #12749:
URL: https://github.com/apache/shardingsphere/pull/12749#discussion_r716488921
##########
File path:
shardingsphere-scaling/shardingsphere-scaling-dialect/shardingsphere-scaling-opengauss/src/main/java/org/apache/shardingsphere/scaling/opengauss/component/OpenGaussWalDumper.java
##########
@@ -57,6 +61,8 @@
private final OpenGaussLogicalReplication logicalReplication = new
OpenGaussLogicalReplication();
private final WalEventConverter walEventConverter;
+
+ private String slotName = OpenGaussLogicalReplication.SLOT_NAME_PREFIX;
Review comment:
no, this filed init need Connection, but we not save Connection as
object field.
it's not worth the cost to init this field by create a connection to
database.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
