totalo commented on a change in pull request #13297:
URL: https://github.com/apache/shardingsphere/pull/13297#discussion_r737110509
##########
File path:
shardingsphere-features/shardingsphere-encrypt/shardingsphere-encrypt-distsql/shardingsphere-encrypt-distsql-parser/src/main/antlr4/imports/encrypt/RDLStatement.g4
##########
@@ -78,3 +78,7 @@ algorithmProperties
algorithmProperty
: key=(IDENTIFIER | STRING) EQ value=(NUMBER | INT | STRING)
;
+
+queryWithCipherColumn
+ : 'true' | 'false'
Review comment:
I think we may be able to support uppercase input, but the input is
definitely limited. It cannot be all strings, and the parsed result may be the
default false. Rather than not reminding the default value, I think the error
can make users more aware of this problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
