totalo commented on a change in pull request #13297:
URL: https://github.com/apache/shardingsphere/pull/13297#discussion_r737409968
##########
File path:
shardingsphere-features/shardingsphere-encrypt/shardingsphere-encrypt-distsql/shardingsphere-encrypt-distsql-parser/src/main/antlr4/imports/encrypt/RDLStatement.g4
##########
@@ -78,3 +78,10 @@ algorithmProperties
algorithmProperty
: key=(IDENTIFIER | STRING) EQ value=(NUMBER | INT | STRING)
;
+
+queryWithCipherColumn
+ : 'true'
+ | 'false'
+ | 'TRUE'
+ | 'FALSE'
Review comment:
At first, I was a little entangled whether it was appropriate to set
these two as keywords.
##########
File path:
docs/document/content/user-manual/shardingsphere-proxy/usage/distsql/syntax/rdl/rdl-encrypt-rule.cn.md
##########
@@ -30,6 +30,7 @@ algorithmProperty:
- `PLAIN` 指定明文数据列，`CIPHER` 指定密文数据列
- `encryptAlgorithmType` 指定加密算法类型，请参考
[加密算法](/cn/user-manual/shardingsphere-jdbc/configuration/built-in-algorithm/encrypt/)
- 重复的 `tableName` 将无法被创建
+- `queryWithCipherColumn` support uppercase or lowercase true or false
Review comment:
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
