[GitHub] [shardingsphere] linghengqian edited a comment on pull request #15260: [issue-15259] upgrade snakeyaml due to cve

Sat, 12 Feb 2022 02:22:33 -0800 


linghengqian edited a comment on pull request #15260:
URL: https://github.com/apache/shardingsphere/pull/15260#issuecomment-1037101973


   @pjfanning Just a request for help. I noticed that version `1.16-1.18` of 
`snakeyaml`,  `org.yaml.snakeyaml.constructor.Constructor` contained two 
properties, `typeTags` and `typeDefinitions`. But in version `1.19` these two 
properties were removed. Can you point out the reason for this modification of 
`snakeyaml`? I can't find a description of it in the changelog, which makes 
`org.apache.shardingsphere.infra.yaml.engine.constructor.ShardingSphereYamlConstructor`
 useless after upgrading the version.
   - `snakeyaml.version` <= `1.18`
   - 
![image](https://user-images.githubusercontent.com/20187731/153706604-c6e4dd64-4f5b-46d5-9e64-9d69d1b0b0cc.png)
   - 
![image](https://user-images.githubusercontent.com/20187731/153706628-34cbc239-80d9-4547-a150-b6fb1c87fc2e.png)
   
   
   - `snakeyaml.version` >= `1.19`
   - 
![image](https://user-images.githubusercontent.com/20187731/153706668-d714d780-6285-4160-95f6-8fe9e4e136ca.png)
   - 
![image](https://user-images.githubusercontent.com/20187731/153706655-58222bbe-34bf-4e2b-9d8b-0e3937b5bb54.png)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to