linghengqian commented on pull request #15260: URL: https://github.com/apache/shardingsphere/pull/15260#issuecomment-1037195109
> what I don't understand is mockYamlExecuteProcessContext and YamlEngine.marshal > > For YamlExecuteProcessContext it returns: > > ``` > unitStatuses: !!set > ? status: EXECUTE_STATUS_DONE > unitID: '159917166' > : null > ``` > > Wouldn't yaml like this be a better representation (generated using jackson-dataformat-yaml)?: > > ``` > executionID: null > schemaName: null > username: null > hostname: null > sql: null > unitStatuses: > - unitID: "159917166" > status: "EXECUTE_STATUS_DONE" > startTimeMillis: null > ``` > > The custom yaml code in shardingsphere confuses me - I just think it would be easier to use jackson-dataformat-yaml instead. jackson-dataformat-yaml uses snakeyaml but recent versions of jackson-dataformat-yaml use up to date versions of snakeyaml Honestly I've never tried customizing the classes `org.yaml.snakeyaml.representer.Representer` and `org.yaml.snakeyaml.constructor.Constructor` , the friend last modified `org.apache.shardingsphere.infra.yaml.engine.YamlEngine` of class is @sandynz , can you please explain it ? I didn't see much information in https://shardingsphere.apache.org/document/current/en/dev-manual/configuration/ . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
