sandynz commented on a change in pull request #15408:
URL: https://github.com/apache/shardingsphere/pull/15408#discussion_r806713926
##########
File path:
shardingsphere-kernel/shardingsphere-data-pipeline/shardingsphere-data-pipeline-core/src/main/java/org/apache/shardingsphere/data/pipeline/core/api/GovernanceRepositoryAPI.java
##########
@@ -98,4 +99,11 @@
* @param value value of data
*/
void persist(String key, String value);
+
+ /**
+ * renew job status.
Review comment:
`renew`'s first character should be uppercase in javadoc, and there
should be a new line between method description and params.
##########
File path:
shardingsphere-kernel/shardingsphere-data-pipeline/shardingsphere-data-pipeline-core/src/main/java/org/apache/shardingsphere/data/pipeline/core/api/impl/RuleAlteredJobAPIImpl.java
##########
@@ -322,10 +322,7 @@ public void switchClusterConfiguration(final
JobConfiguration jobConfig) {
String ruleCacheId = workflowConfig.getRuleCacheId();
Review comment:
Looks `JobStatus.ALMOST_FINISHED` still might be not set, since
`optionalJobContexts` might be empty as discussed before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
