ReyYang commented on a change in pull request #15408:
URL: https://github.com/apache/shardingsphere/pull/15408#discussion_r808750209
##########
File path:
shardingsphere-kernel/shardingsphere-data-pipeline/shardingsphere-data-pipeline-core/src/main/java/org/apache/shardingsphere/data/pipeline/scenario/rulealtered/RuleAlteredJobScheduler.java
##########
@@ -69,6 +63,17 @@ public void stop() {
each.stop();
each.close();
}
+ // TODO clean up should be done after the task is complete.
+ try {
+ TimeUnit.SECONDS.sleep(1);
+ } catch (InterruptedException e) {
+ e.printStackTrace();
+ }
+ log.info("almost finished, preparer cleanup, job {}",
jobContext.getJobId());
+ RuleAlteredJobPreparer jobPreparer = jobContext.getJobPreparer();
+ if (null != jobPreparer) {
+ jobPreparer.cleanup(jobContext);
+ }
Review comment:
Currently, the replication slot is deleted only after the task is
complete
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
