totalo commented on a change in pull request #15980:
URL: https://github.com/apache/shardingsphere/pull/15980#discussion_r823782836
##########
File path:
shardingsphere-test/shardingsphere-pipeline-test/src/test/java/org/apache/shardingsphere/data/pipeline/core/record/RecordUtilTest.java
##########
@@ -0,0 +1,47 @@
+package org.apache.shardingsphere.data.pipeline.core.record;
+
+import
org.apache.shardingsphere.data.pipeline.api.ingest.position.PlaceholderPosition;
+import org.apache.shardingsphere.data.pipeline.api.ingest.record.Column;
+import org.apache.shardingsphere.data.pipeline.api.ingest.record.DataRecord;
+import org.junit.Test;
+
+import java.util.Collections;
+import java.util.List;
+
+import static org.hamcrest.CoreMatchers.is;
+import static org.junit.Assert.assertThat;
+
+
+public final class RecordUtilTest {
+ @Test
+ public void assertExtractPrimaryColumns() {
+ DataRecord dataRecord = mockDataRecord("t2");
+ List<Column> actual = RecordUtil.extractPrimaryColumns(dataRecord);
+ assertThat(actual.size(), is(2));
+ }
+
+ @Test
+ public void assertExtractUpdatedColumns() {
+ DataRecord dataRecord = mockDataRecord("t2");
+ List<Column> actual = RecordUtil.extractUpdatedColumns(dataRecord);
Review comment:
`Collection` may be better.
##########
File path:
shardingsphere-test/shardingsphere-pipeline-test/src/test/java/org/apache/shardingsphere/data/pipeline/core/record/RecordUtilTest.java
##########
@@ -0,0 +1,47 @@
+package org.apache.shardingsphere.data.pipeline.core.record;
+
+import
org.apache.shardingsphere.data.pipeline.api.ingest.position.PlaceholderPosition;
+import org.apache.shardingsphere.data.pipeline.api.ingest.record.Column;
+import org.apache.shardingsphere.data.pipeline.api.ingest.record.DataRecord;
+import org.junit.Test;
+
+import java.util.Collections;
+import java.util.List;
+
+import static org.hamcrest.CoreMatchers.is;
+import static org.junit.Assert.assertThat;
+
+
+public final class RecordUtilTest {
+ @Test
+ public void assertExtractPrimaryColumns() {
+ DataRecord dataRecord = mockDataRecord("t2");
+ List<Column> actual = RecordUtil.extractPrimaryColumns(dataRecord);
Review comment:
`Collection` may be better.
##########
File path:
shardingsphere-test/shardingsphere-pipeline-test/src/test/java/org/apache/shardingsphere/data/pipeline/core/record/RecordUtilTest.java
##########
@@ -0,0 +1,47 @@
+package org.apache.shardingsphere.data.pipeline.core.record;
+
+import
org.apache.shardingsphere.data.pipeline.api.ingest.position.PlaceholderPosition;
+import org.apache.shardingsphere.data.pipeline.api.ingest.record.Column;
+import org.apache.shardingsphere.data.pipeline.api.ingest.record.DataRecord;
+import org.junit.Test;
+
+import java.util.Collections;
+import java.util.List;
+
+import static org.hamcrest.CoreMatchers.is;
+import static org.junit.Assert.assertThat;
+
+
+public final class RecordUtilTest {
+ @Test
+ public void assertExtractPrimaryColumns() {
+ DataRecord dataRecord = mockDataRecord("t2");
+ List<Column> actual = RecordUtil.extractPrimaryColumns(dataRecord);
+ assertThat(actual.size(), is(2));
+ }
+
+ @Test
+ public void assertExtractUpdatedColumns() {
+ DataRecord dataRecord = mockDataRecord("t2");
+ List<Column> actual = RecordUtil.extractUpdatedColumns(dataRecord);
+ assertThat(actual.size(), is(3));
+ }
+
+ @Test
+ public void assertExtractConditionalColumns() {
+ DataRecord dataRecord = mockDataRecord("t2");
+ List<Column> actual = RecordUtil.extractConditionColumns(dataRecord,
Collections.singleton("c1"));
Review comment:
`Collection` may be better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
