totalo commented on a change in pull request #15980: URL: https://github.com/apache/shardingsphere/pull/15980#discussion_r823853545
########## File path: shardingsphere-test/shardingsphere-pipeline-test/src/test/java/org/apache/shardingsphere/data/pipeline/core/record/RecordUtilTest.java ########## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.shardingsphere.data.pipeline.core.record; + +import org.apache.shardingsphere.data.pipeline.api.ingest.position.PlaceholderPosition; +import org.apache.shardingsphere.data.pipeline.api.ingest.record.Column; +import org.apache.shardingsphere.data.pipeline.api.ingest.record.DataRecord; +import org.junit.Test; + +import java.util.Collections; +import java.util.Collection; + +import static org.hamcrest.CoreMatchers.is; +import static org.junit.Assert.assertThat; + +public final class RecordUtilTest { + + @Test + public void assertExtractPrimaryColumns() { + DataRecord dataRecord = mockDataRecord("t2"); + Collection<Column> actual = RecordUtil.extractPrimaryColumns(dataRecord); Review comment: There is one more problem, in addition to the number of elements, we'd better check the specific content. ########## File path: shardingsphere-test/shardingsphere-pipeline-test/src/test/java/org/apache/shardingsphere/data/pipeline/core/record/RecordUtilTest.java ########## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.shardingsphere.data.pipeline.core.record; + +import org.apache.shardingsphere.data.pipeline.api.ingest.position.PlaceholderPosition; +import org.apache.shardingsphere.data.pipeline.api.ingest.record.Column; +import org.apache.shardingsphere.data.pipeline.api.ingest.record.DataRecord; +import org.junit.Test; + +import java.util.Collections; +import java.util.Collection; + +import static org.hamcrest.CoreMatchers.is; +import static org.junit.Assert.assertThat; + +public final class RecordUtilTest { + + @Test + public void assertExtractPrimaryColumns() { + DataRecord dataRecord = mockDataRecord("t2"); + Collection<Column> actual = RecordUtil.extractPrimaryColumns(dataRecord); + assertThat(actual.size(), is(2)); + } + + @Test + public void assertExtractConditionalColumns() { + DataRecord dataRecord = mockDataRecord("t2"); + Collection<Column> actual = RecordUtil.extractConditionColumns(dataRecord, Collections.singleton("c1")); + assertThat(actual.size(), is(3)); + } + + @Test + public void assertExtractUpdatedColumns() { + DataRecord dataRecord = mockDataRecord("t2"); + Collection<Column> actual = RecordUtil.extractUpdatedColumns(dataRecord); + assertThat(actual.size(), is(3)); Review comment: The same as above. ########## File path: shardingsphere-test/shardingsphere-pipeline-test/src/test/java/org/apache/shardingsphere/data/pipeline/core/record/RecordUtilTest.java ########## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.shardingsphere.data.pipeline.core.record; + +import org.apache.shardingsphere.data.pipeline.api.ingest.position.PlaceholderPosition; +import org.apache.shardingsphere.data.pipeline.api.ingest.record.Column; +import org.apache.shardingsphere.data.pipeline.api.ingest.record.DataRecord; +import org.junit.Test; + +import java.util.Collections; +import java.util.Collection; + +import static org.hamcrest.CoreMatchers.is; +import static org.junit.Assert.assertThat; + +public final class RecordUtilTest { + + @Test + public void assertExtractPrimaryColumns() { + DataRecord dataRecord = mockDataRecord("t2"); + Collection<Column> actual = RecordUtil.extractPrimaryColumns(dataRecord); + assertThat(actual.size(), is(2)); + } + + @Test + public void assertExtractConditionalColumns() { + DataRecord dataRecord = mockDataRecord("t2"); + Collection<Column> actual = RecordUtil.extractConditionColumns(dataRecord, Collections.singleton("c1")); + assertThat(actual.size(), is(3)); Review comment: There is one more problem, in addition to the number of elements, we'd better check the specific content. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
