huangdx0726 commented on code in PR #19875:
URL: https://github.com/apache/shardingsphere/pull/19875#discussion_r938562388
##########
shardingsphere-kernel/shardingsphere-data-pipeline/shardingsphere-data-pipeline-core/src/main/java/org/apache/shardingsphere/data/pipeline/core/api/impl/GovernanceRepositoryAPIImpl.java:
##########
@@ -62,26 +60,25 @@ public void persistJobProgress(final RuleAlteredJobContext
jobContext) {
JobProgress jobProgress = new JobProgress();
jobProgress.setStatus(jobContext.getStatus());
jobProgress.setSourceDatabaseType(jobContext.getJobConfig().getSourceDatabaseType());
-
jobProgress.setIncrementalTaskProgressMap(getIncrementalTaskProgressMap(jobContext));
-
jobProgress.setInventoryTaskProgressMap(getInventoryTaskProgressMap(jobContext));
+ jobProgress.setIncremental(getIncrementalTaskProgress(jobContext));
+ jobProgress.setInventory(getInventoryTaskProgress(jobContext));
String value = YamlEngine.marshal(SWAPPER.swapToYaml(jobProgress));
repository.persist(PipelineMetaDataNode.getScalingJobOffsetPath(jobContext.getJobId(),
jobContext.getShardingItem()), value);
}
- private Map<String, IncrementalTaskProgress>
getIncrementalTaskProgressMap(final RuleAlteredJobContext jobContext) {
- Map<String, IncrementalTaskProgress> result = new
HashMap<>(jobContext.getIncrementalTasks().size(), 1);
- for (IncrementalTask each : jobContext.getIncrementalTasks()) {
- result.put(each.getTaskId(), each.getProgress());
- }
- return result;
+ private IncrementalTaskProgress getIncrementalTaskProgress(final
RuleAlteredJobContext jobContext) {
+ return new IncrementalTaskProgress(
+ jobContext.getIncrementalTasks()
+ .stream().collect(Collectors.toMap(IncrementalTask::getTaskId,
each ->
each.getProgress().getIncrementalTaskProgressItemMap().get(each.getTaskId())))
+ );
}
- private Map<String, InventoryTaskProgress>
getInventoryTaskProgressMap(final RuleAlteredJobContext jobContext) {
- Map<String, InventoryTaskProgress> result = new
HashMap<>(jobContext.getInventoryTasks().size(), 1);
- for (InventoryTask each : jobContext.getInventoryTasks()) {
- result.put(each.getTaskId(), each.getProgress());
- }
- return result;
+ private InventoryTaskProgress getInventoryTaskProgress(final
RuleAlteredJobContext jobContext) {
+ return new InventoryTaskProgress(
+ jobContext.getInventoryTasks()
+ .stream()
+ .collect(Collectors.toMap(InventoryTask::getTaskId,
each ->
each.getProgress().getInventoryTaskProgressItemMap().get(each.getTaskId())))
+ );
}
Review Comment:
Ok， i will fix it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
