huangdx0726 commented on code in PR #19875:
URL: https://github.com/apache/shardingsphere/pull/19875#discussion_r938562161
##########
shardingsphere-kernel/shardingsphere-data-pipeline/shardingsphere-data-pipeline-api/src/main/java/org/apache/shardingsphere/data/pipeline/api/job/progress/JobProgress.java:
##########
@@ -46,19 +41,17 @@ public final class JobProgress implements
PipelineJobProgress {
private boolean active;
- private Map<String, InventoryTaskProgress> inventoryTaskProgressMap;
+ private InventoryTaskProgress inventory;
- private Map<String, IncrementalTaskProgress> incrementalTaskProgressMap;
+ private IncrementalTaskProgress incremental;
Review Comment:
OK, i try to fix it
##########
shardingsphere-kernel/shardingsphere-data-pipeline/shardingsphere-data-pipeline-api/src/main/java/org/apache/shardingsphere/data/pipeline/api/task/progress/IncrementalTaskProgress.java:
##########
@@ -17,24 +17,49 @@
package org.apache.shardingsphere.data.pipeline.api.task.progress;
-import lombok.AllArgsConstructor;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+import java.util.stream.Collectors;
import lombok.Getter;
-import lombok.NoArgsConstructor;
+import lombok.RequiredArgsConstructor;
import lombok.Setter;
import lombok.ToString;
import
org.apache.shardingsphere.data.pipeline.api.ingest.position.IngestPosition;
/**
* Incremental task progress.
*/
-@NoArgsConstructor
-@AllArgsConstructor
+@RequiredArgsConstructor
@Getter
@Setter
@ToString
public final class IncrementalTaskProgress implements TaskProgress {
- private volatile IngestPosition<?> position;
+ private final Map<String, IncrementalTaskProgressItem>
incrementalTaskProgressItemMap;
- private IncrementalTaskDelay incrementalTaskDelay = new
IncrementalTaskDelay();
Review Comment:
I find the definition of `RuleAlteredJobContext` as follows，so i changed it
```java
private final Collection<InventoryTask> inventoryTasks = new LinkedList<>();
private final Collection<IncrementalTask> incrementalTasks = new
LinkedList<>();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
