dragon-zhang commented on code in PR #3433: URL: https://github.com/apache/incubator-shenyu/pull/3433#discussion_r882275028
########## shenyu-common/src/main/java/org/apache/shenyu/common/dto/convert/plugin/TarsRegisterConfig.java: ########## @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.shenyu.common.dto.convert.plugin; + +import java.io.Serializable; +import java.util.Objects; + +/** + * The type tars register config. + */ +public class TarsRegisterConfig implements Serializable { + + private static final long serialVersionUID = -1124348422759120146L; + + private String threadpool; + + private Integer corethreads; + + private Integer threads; + + private Integer queues; + + /** + * get threadpool. + * + * @return threadpool + */ + public String getThreadpool() { + return threadpool; + } + + /** + * set threadpool. + * + * @param threadpool threadpool + */ + public void setThreadpool(final String threadpool) { + this.threadpool = threadpool; + } + + /** + * get corethreads. + * + * @return corethreads + */ + public Integer getCorethreads() { + return corethreads; + } + + /** + * set corethreads. + * + * @param corethreads corethreads + */ + public void setCorethreads(final Integer corethreads) { + this.corethreads = corethreads; + } + + /** + * get threads. + * + * @return threads + */ + public Integer getThreads() { + return threads; + } + + /** + * set threads. + * + * @param threads threads + */ + public void setThreads(final Integer threads) { + this.threads = threads; + } + + /** + * get queues. + * + * @return queues + */ + public Integer getQueues() { + return queues; + } + + /** + * set queues. + * + * @param queues queues + */ + public void setQueues(final Integer queues) { + this.queues = queues; + } + + @Override + public boolean equals(final Object o) { + if (this == o) { + return true; + } + if (o == null || getClass() != o.getClass()) { + return false; + } + TarsRegisterConfig that = (TarsRegisterConfig) o; + return Objects.equals(threadpool, that.threadpool); Review Comment: missed other fields ########## shenyu-common/src/main/java/org/apache/shenyu/common/dto/convert/plugin/TarsRegisterConfig.java: ########## @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.shenyu.common.dto.convert.plugin; + +import java.io.Serializable; +import java.util.Objects; + +/** + * The type tars register config. + */ +public class TarsRegisterConfig implements Serializable { + + private static final long serialVersionUID = -1124348422759120146L; + + private String threadpool; + + private Integer corethreads; + + private Integer threads; + + private Integer queues; + + /** + * get threadpool. + * + * @return threadpool + */ + public String getThreadpool() { + return threadpool; + } + + /** + * set threadpool. + * + * @param threadpool threadpool + */ + public void setThreadpool(final String threadpool) { + this.threadpool = threadpool; + } + + /** + * get corethreads. + * + * @return corethreads + */ + public Integer getCorethreads() { + return corethreads; + } + + /** + * set corethreads. + * + * @param corethreads corethreads + */ + public void setCorethreads(final Integer corethreads) { + this.corethreads = corethreads; + } + + /** + * get threads. + * + * @return threads + */ + public Integer getThreads() { + return threads; + } + + /** + * set threads. + * + * @param threads threads + */ + public void setThreads(final Integer threads) { + this.threads = threads; + } + + /** + * get queues. + * + * @return queues + */ + public Integer getQueues() { + return queues; + } + + /** + * set queues. + * + * @param queues queues + */ + public void setQueues(final Integer queues) { + this.queues = queues; + } + + @Override + public boolean equals(final Object o) { + if (this == o) { + return true; + } + if (o == null || getClass() != o.getClass()) { + return false; + } + TarsRegisterConfig that = (TarsRegisterConfig) o; + return Objects.equals(threadpool, that.threadpool); + } + + @Override + public int hashCode() { + return Objects.hash(threadpool); Review Comment: missed other fields -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
