dragon-zhang commented on code in PR #3433:
URL: https://github.com/apache/incubator-shenyu/pull/3433#discussion_r884098050
##########
shenyu-admin/src/main/resources/sql-script/h2/schema.sql:
##########
@@ -533,6 +533,10 @@ INSERT IGNORE INTO plugin_handle (`id`,
`plugin_id`,`field`,`label`,`data_type`,
INSERT IGNORE INTO plugin_handle (`id`,
`plugin_id`,`field`,`label`,`data_type`,`type`,`sort`,`ext_obj`) VALUES
('1529402613204172865', '30', 'maxActive', 'maxActive', 1, 3, 9,
'{"required":"0","defaultValue":"8","rule":""}');
INSERT IGNORE INTO plugin_handle (`id`,
`plugin_id`,`field`,`label`,`data_type`,`type`,`sort`,`ext_obj`) VALUES
('1529402613204172866', '30', 'maxWait', 'maxWait', 3, 3, 10,
'{"required":"0","defaultValue":"-1","rule":""}');
INSERT IGNORE INTO plugin_handle (`id`,
`plugin_id`,`field`,`label`,`data_type`,`type`,`sort`,`ext_obj`) VALUES
('1529402613204172867', '30', 'timeoutSeconds', 'timeoutSeconds', 1, 2, 0,
'{"required":"0","defaultValue":"60","rule":""}');
+INSERT IGNORE INTO plugin_handle (`id`,
`plugin_id`,`field`,`label`,`data_type`,`type`,`sort`,`ext_obj`) VALUES
('1529402613204172868','13', 'corethreads', 'corethreads', 1, 3, 0,
'{"required":"0","defaultValue":"0","placeholder":"corethreads","rule":""}');
+INSERT IGNORE INTO plugin_handle (`id`,
`plugin_id`,`field`,`label`,`data_type`,`type`,`sort`,`ext_obj`) VALUES
('1529402613204172869''13', 'threads', 'threads', 1, 3, 0,
'{"required":"0","defaultValue":"2147483647","placeholder":"threads","rule":""}');
+INSERT IGNORE INTO plugin_handle (`id`,
`plugin_id`,`field`,`label`,`data_type`,`type`,`sort`,`ext_obj`) VALUES
('1529402613204172870''13', 'queues', 'queues', 1, 3, 0,
'{"required":"0","defaultValue":"0","placeholder":"queues","rule":""}');
+INSERT IGNORE INTO plugin_handle (`id`,
`plugin_id`,`field`,`label`,`data_type`,`type`,`sort`,`ext_obj`) VALUES
('1529402613204172871''13', 'threadpool', 'threadpool', 3, 3, 0,
'{"required":"0","defaultValue":"cached","placeholder":"threadpool","rule":""}');
Review Comment:
should be `'1529402613204172871','13'`
##########
db/init/pg/create-table.sql:
##########
@@ -641,7 +641,7 @@ INSERT INTO "public"."plugin" VALUES ('1', 'sign', NULL,
'Authentication', 20, 0
INSERT INTO "public"."plugin" VALUES ('10', 'sentinel', NULL,
'FaultTolerance', 140, 0, '2022-05-25 18:08:01', '2022-05-25 18:08:01');
INSERT INTO "public"."plugin" VALUES ('11', 'sofa',
'{"protocol":"zookeeper","register":"127.0.0.1:2181"}', 'Proxy', 310, 0,
'2022-05-25 18:08:01', '2022-05-25 18:08:01');
INSERT INTO "public"."plugin" VALUES ('12', 'resilience4j', NULL,
'FaultTolerance', 310, 0, '2022-05-25 18:08:01', '2022-05-25 18:08:01');
-INSERT INTO "public"."plugin" VALUES ('13', 'tars',
'{"multiSelectorHandle":"1","multiRuleHandle":"0"}', 'Proxy', 310, 0,
'2022-05-25 18:08:01', '2022-05-25 18:08:01');
+INSERT INTO "public"."plugin" VALUES ('13', 'tars',
'{"multiSelectorHandle":"1","multiRuleHandle":"0","corethreads":0,"threads":2147483647,"queues":0,"threadpool":""}',
'Proxy', 310, 0, '2022-05-25 18:08:01', '2022-05-25 18:08:01');
Review Comment:
remove the thread pool config, too
##########
shenyu-admin/src/main/resources/sql-script/h2/schema.sql:
##########
@@ -360,7 +360,7 @@ INSERT IGNORE INTO `plugin` (`id`, `name`, `role`, `sort`,
`enabled`) VALUES ('9
INSERT IGNORE INTO `plugin` (`id`, `name`, `role`, `sort`, `enabled`) VALUES
('10','sentinel', 'FaultTolerance', 140,'0');
INSERT IGNORE INTO `plugin` (`id`, `name`, `role`, `sort`, `config`,
`enabled`) VALUES ('11','sofa', 'Proxy', 310,
'{"protocol":"zookeeper","register":"127.0.0.1:2181"}', '0');
INSERT IGNORE INTO `plugin` (`id`, `name`, `role`, `sort`, `enabled`) VALUES
('12','resilience4j', 'FaultTolerance', 310,'0');
-INSERT IGNORE INTO `plugin` (`id`, `name`, `role`, `sort`, `config`,
`enabled`) VALUES ('13', 'tars', 'Proxy',
310,'{"multiSelectorHandle":"1","multiRuleHandle":"0"}','0');
+INSERT IGNORE INTO `plugin` (`id`, `name`, `role`, `sort`, `config`,
`enabled`) VALUES ('13', 'tars', 'Proxy',
310,'{"multiSelectorHandle":"1","multiRuleHandle":"0","corethreads":0,"threads":2147483647,"queues":0,"threadpool":""}','0');
Review Comment:
remove the thread pool config, too
##########
db/init/mysql/schema.sql:
##########
@@ -564,7 +564,7 @@ INSERT INTO `plugin` VALUES ('1', 'sign', NULL,
'Authentication', 20, 0, '2022-0
INSERT INTO `plugin` VALUES ('10', 'sentinel', NULL, 'FaultTolerance', 140, 0,
'2022-05-25 18:02:53', '2022-05-25 18:02:53');
INSERT INTO `plugin` VALUES ('11', 'sofa',
'{\"protocol\":\"zookeeper\",\"register\":\"127.0.0.1:2181\"}', 'Proxy', 310,
0, '2022-05-25 18:02:53', '2022-05-25 18:02:53');
INSERT INTO `plugin` VALUES ('12', 'resilience4j', NULL, 'FaultTolerance',
310, 0, '2022-05-25 18:02:53', '2022-05-25 18:02:53');
-INSERT INTO `plugin` VALUES ('13', 'tars',
'{\"multiSelectorHandle\":\"1\",\"multiRuleHandle\":\"0\"}', 'Proxy', 310, 0,
'2022-05-25 18:02:53', '2022-05-25 18:02:53');
+INSERT INTO `plugin` VALUES ('13', 'tars',
'{\"multiSelectorHandle\":\"1\",\"multiRuleHandle\":\"0\",\"corethreads\":0,\"threads\":2147483647,\"queues\":0,\"threadpool\":\"\"}',
'Proxy', 310, 0, '2022-05-25 18:02:53', '2022-05-25 18:02:53');
Review Comment:
remove the thread pool config.
##########
db/init/oracle/schema.sql:
##########
@@ -780,7 +780,7 @@ INSERT /*+ IGNORE_ROW_ON_DUPKEY_INDEX(plugin(id)) */ INTO
plugin (id, name, role
INSERT /*+ IGNORE_ROW_ON_DUPKEY_INDEX(plugin(id)) */ INTO plugin (id, name,
role, sort, enabled) VALUES ('10','sentinel', 'FaultTolerance', 140,'0');
INSERT /*+ IGNORE_ROW_ON_DUPKEY_INDEX(plugin(id)) */ INTO plugin (id, name,
role, sort, config, enabled) VALUES ('11','sofa', 'Proxy', 310,
'{"protocol":"zookeeper","register":"127.0.0.1:2181"}', '0');
INSERT /*+ IGNORE_ROW_ON_DUPKEY_INDEX(plugin(id)) */ INTO plugin (id, name,
role, sort, enabled) VALUES ('12','resilience4j', 'FaultTolerance', 310,'0');
-INSERT /*+ IGNORE_ROW_ON_DUPKEY_INDEX(plugin(id)) */ INTO plugin (id, name,
role, sort, config, enabled) VALUES ('13', 'tars', 'Proxy',
310,'{"multiSelectorHandle":"1","multiRuleHandle":"0"}','0');
+INSERT /*+ IGNORE_ROW_ON_DUPKEY_INDEX(plugin(id)) */ INTO plugin (id, name,
role, sort, config, enabled) VALUES ('13', 'tars', 'Proxy',
310,'{"multiSelectorHandle":"1","multiRuleHandle":"0","corethreads":0,"threads":2147483647,"queues":0,"threadpool":""}','0');
Review Comment:
remove the thread pool config, too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
