dragon-zhang commented on code in PR #4352:
URL: https://github.com/apache/shenyu/pull/4352#discussion_r1103585772
##########
shenyu-plugin/shenyu-plugin-brpc/src/main/java/org/apache/shenyu/plugin/brpc/cache/ApplicationConfigCache.java:
##########
@@ -152,26 +173,44 @@ public AsyncGenericService build(final MetaData metaData)
{
*/
public AsyncGenericService get(final String path) {
try {
- return cache.get(path);
+ return serviceCache.get(path);
} catch (ExecutionException e) {
throw new ShenyuBrpcPluginException(e.getCause());
}
}
+ /**
+ * init brpc service config.
+ *
+ * @param metaData the meta data
+ * @return service config
+ */
+ public ServiceConfig initServiceConfig(final MetaData metaData) {
Review Comment:
In `org.apache.shenyu.plugin.brpc.handler.BrpcMetaDataHandler#handle`, maybe
just change
`org.apache.shenyu.plugin.brpc.cache.ApplicationConfigCache#initService` to
`org.apache.shenyu.plugin.brpc.cache.ApplicationConfigCache#initServiceConfig` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
