dragon-zhang commented on code in PR #4352:
URL: https://github.com/apache/shenyu/pull/4352#discussion_r1103586434
##########
shenyu-plugin/shenyu-plugin-brpc/src/main/java/org/apache/shenyu/plugin/brpc/proxy/BrpcProxyService.java:
##########
@@ -81,8 +81,7 @@ public Mono<Object> genericInvoker(final String body, final
MetaData metaData, f
}
}
initThreadPool();
- CompletableFuture<Object> future = null;
- future = new CompletableFuture<>().supplyAsync(() ->
getValue(metaData, params), threadPool);
+ CompletableFuture<Object> future = CompletableFuture.supplyAsync(() ->
getValue(metaData, params), threadPool);
Review Comment:
In the future, we should use
`com.baidu.cloud.starlight.api.rpc.threadpool.ThreadPoolFactory` SPI to impl
it, this is a todo list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
