moremind commented on code in PR #4941:
URL: https://github.com/apache/shenyu/pull/4941#discussion_r1280329194
##########
shenyu-admin/src/main/java/org/apache/shenyu/admin/service/converter/AbstractSelectorHandleConverter.java:
##########
@@ -68,7 +68,7 @@ public String handler(final String handle, final
List<CommonUpstream> aliveList)
*/
@Override
public <T extends CommonUpstream> List<T> updateStatusAndFilter(final
List<T> existList, final List<? extends CommonUpstream> aliveList) {
- if (CollectionUtils.isEmpty(aliveList) ||
CollectionUtils.isEmpty(existList)) {
+ if (aliveList == null) {
Review Comment:
Objects.isNull
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
