dragon-zhang commented on code in PR #4941:
URL: https://github.com/apache/shenyu/pull/4941#discussion_r1280655692
##########
shenyu-common/src/main/java/org/apache/shenyu/common/dto/convert/selector/DubboUpstream.java:
##########
@@ -246,8 +246,6 @@ public boolean equals(final Object o) {
}
DubboUpstream that = (DubboUpstream) o;
return port == that.port
- && weight == that.weight
- && warmup == that.warmup
Review Comment:
`hashCode` also need modify.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
