Aias00 commented on PR #6361:
URL: https://github.com/apache/shenyu/pull/6361#issuecomment-4645764006

   Follow-up for the PR rollup failure after the ingress fix: `it / 
shenyu-integrated-test-http` failed in `SentinelPluginTest.testFallbackUri` 
with `expected: <202> but was: <404>`.
   
   Root cause: the test used `fallback:/http/test/request/accepted`, but 
`fallback:` dispatch is handled locally by the gateway `DispatcherHandler`; it 
is not a fresh divide upstream request. In CI this resolved as a missing 
backend static resource (`No static resource http/test/request/accepted`) 
instead of exercising the sentinel fallback endpoint.
   
   I pushed `7dc8849cc` to point the fallback URI at the existing gateway-local 
`fallback:/fallback/sentinel` endpoint and assert the sentinel fallback enum 
code/message, so the test now verifies the intended behavior without depending 
on an upstream route re-entry.
   
   Local verification:
   - `./mvnw -B -f shenyu-integrated-test/pom.xml -pl 
shenyu-integrated-test-http -am -DskipTests -Dmaven.javadoc.skip=true 
test-compile`
   - `git diff --check`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to