Aias00 commented on PR #6361:
URL: https://github.com/apache/shenyu/pull/6361#issuecomment-4645825391

   Follow-up for run https://github.com/apache/shenyu/actions/runs/27118273553: 
the sentinel fallback test reached `fallback:/fallback/sentinel`, but the 
response was 405 because `FallbackHandler` preserves the original request 
method. The original request is POST, while `DefaultFallbackController` only 
exposed GET mappings.
   
   I pushed `e042d2fbd` to make the default fallback endpoints method-agnostic 
`@RequestMapping` targets and added a POST regression test for 
`/fallback/sentinel`.
   
   Local verification:
   - `./mvnw -B -pl shenyu-web -DskipITs -DskipTests=false 
-Dtest=DefaultFallbackControllerTest -Dmaven.javadoc.skip=true test`
   - `./mvnw -B -f shenyu-integrated-test/pom.xml -pl 
shenyu-integrated-test-http -am -DskipTests -Dmaven.javadoc.skip=true 
test-compile`
   - `git diff --check`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to