dengliming opened a new issue, #620:
URL: https://github.com/apache/shenyu-dashboard/issues/620

   ## Description
   `src/utils/download.js` calls `fetch`, then `response.blob()` and triggers a 
download without checking `response.ok`/`status`, and without the 401 handling 
that `request()` has.
   
   ## Location
   (Lines refer to `master @ 83969a5`.)
   - `src/utils/download.js:43-56`
   
   ## Impact
   When the token has expired (or the export fails), the user downloads a file 
named `download` that contains the error JSON, and the session-expired flow is 
not triggered.
   
   ## Suggested fix
   Check `response.ok`; on failure parse the JSON error, show a notification, 
dispatch `login/logout` on 401, and do not create a download.
   
   ## Related existing
   None
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to