sunnysabor commented on issue #6668:
URL: https://github.com/apache/shenyu/issues/6668#issuecomment-5935993173

   I checked the current `upstream/master` (`09c6a528`) against this report. 
The worker-thread shutdown part is already addressed by merged #6982 
(`58dd5a517`): `shutdown()` interrupts the worker under the write lock, 
`Worker.run()` exits when interrupted, and 
`HierarchicalWheelTimerTest#testShutdownStopsWorkerAndRejectsNewTasks` joins 
the worker and asserts it has terminated.
   
   The unbounded `LinkedBlockingQueue` remains. That is a separate 
overload/backpressure question: a bounded queue needs an explicit overflow 
policy because rejecting an expired timer callback can leave caller state 
stale, while caller-runs can stall the timing-wheel worker. Could we narrow 
this issue to the queue/backpressure behavior and agree on the expected 
overload semantics, while marking the worker-leak portion resolved by #6982?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to