hussnainahmedd commented on PR #702: URL: https://github.com/apache/shenyu-dashboard/pull/702#issuecomment-6100099805
Thanks for the review! Addressed the high-severity finding: the unauthorized-download test in `src/utils/download.test.js` still asserted the old hardcoded message (`请求错误 401: undefined`), but `checkStatus` now emits the localized `SHENYU.REQUEST.ERROR` value. Updated the test to mock `getIntlContent` (same pattern as the other test files in this PR) and assert the translated notification message. Verified locally: ESLint clean, 5/5 jest tests pass. On the chart-label finding (`System/Instance`): verified that the y-axis label was hardcoded Chinese before this PR, so the label staying static across a language change is pre-existing behavior, not a regression from this change. Making the chart re-render on locale change would be a behavior change beyond this PR's scope (hardcoded strings → translation keys), so I've left that untouched — happy to follow the maintainer's call on whether it belongs here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
