hussnainahmedd commented on PR #702: URL: https://github.com/apache/shenyu-dashboard/pull/702#issuecomment-6107405177
Fixed the grammar nit from the review: `SHENYU.MCP.TOOLS.PARAM.INCOMPLETE` now reads "parameters are incomplete; please fill in the name and type" (was a comma splice without a verb). The composed message becomes e.g. "Row 1 parameters are incomplete; please fill in the name and type". Pushed as `3cf81bc4`. On the locale-staleness findings (MCP config modal preview/copied fields and chart labels not refreshing after a language switch): verified these are pre-existing — both components regenerate/translate their content only on their original triggers (selectorList changes for the modal, initial render for the charts), independent of this PR. Making them fully locale-reactive would change runtime behavior beyond the scope of this i18n key-replacement PR, so I've left that untouched. Happy to follow up separately if you'd like it addressed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
