konlue commented on PR #7938: URL: https://github.com/apache/shenyu/pull/7938#issuecomment-6315933695
All addressed: 1. **In-flight ID cleanup on session reset**: `Connect` now discards the in-flight ids whenever the session is not resumed — covering both the clean-session reconnect and the no-stored-session case — with the regression test you sketched (register an id, reconnect with `cleanSession=1`, republish the same id, assert delivery). 2. **Deterministic retransmit test**: the test now uses a second packet id as an ordering barrier before the cumulative `times(2)` assertion, so it fails deterministically without the dedup. Also took the non-blocking points: - The empty-set two-arg cleanup in `release`. - A debug log on the no-`clientId` fallback. - Distinct packet ids in the packet-id-allocation test. - A Javadoc note on why the key is the client id. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
