konlue commented on PR #7938: URL: https://github.com/apache/shenyu/pull/7938#issuecomment-6331836150
Pushed the fixture fix, and you were right to catch it — thanks also for the pointer to audit the rest. - **Fixture fix**: `MqttFactoryTest.setUp` now registers `InflightRepository`. I grepped the module for tests that drive a real `Connect` and checked all five. - **Rebase discovery**: After rebasing onto latest `master`, it also surfaced `ClientIdTakeoverTest` (merged through #7939), which reached `Connect` without the registration — same trap, now fixed too. - **Merge conflict**: The merge brought a conflict in `Disconnect.cleanChannel`, resolved by keeping #7918's ownership fence and moving #7919's in-flight cleanup inside it. - **Checkstyle fix**: `Connect.connect` crossed the checkstyle `MethodLength` limit once the takeover block landed, so the takeover was extracted into `takeOverClientId()` (pure move). Full module 137/137 green and checkstyle clean locally — `pr_build` should go green on this head. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
