harshkha3417 commented on PR #7762: URL: https://github.com/apache/shenyu/pull/7762#issuecomment-6330308415
Thanks @Aias00 for the detailed review! I have rebased the branch onto latest `master` to resolve the merge conflict with the `boundPort` refactoring, and addressed all non-blocking observations: 1. **Rebase & Constructor Alignment:** Resolved the merge conflict with `boundPort` by removing `ServerProperties` across the listener and tests while maintaining the worker isolation and deadline tracking. 2. **Ambiguity Removal in Tests:** Updated `testMalformedHeartbeatTimeoutMsFallback` to feed `"invalid"` instead of `"4s"`. 3. **Cancellation Semantics:** Added an explanatory comment on `future.cancel(true)` regarding OkHttp socket write interrupt semantics. 4. **Log Noise:** Downgraded the overlapping in-flight skip message to `LOG.debug` to prevent log saturation during prolonged Admin stalls. 5. **Escape Hatch Javadoc:** Documented that `heartbeatTimeoutMs <= 0` (e.g. `-1`) disables the deadline entirely. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
