SevenPointOld commented on a change in pull request #1213: provides a
optional-plugin for tracking ignores enhancement(#1203)
URL:
https://github.com/apache/incubator-skywalking/pull/1213#discussion_r187903231
##########
File path:
apm-sniffer/optional-plugins/optional-spring-plugins/spring-annotation-plugin/pom.xml
##########
@@ -28,6 +28,10 @@
<artifactId>apm-spring-annotation-plugin</artifactId>
+ <properties>
+ <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+ <sdk.plugin.related.dir>/..</sdk.plugin.related.dir>
Review comment:
I think the `sdk.plugin.related.dir` should in `optional-plugins/pom.xml`,
because it needs to cover the path of the copy
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
