wu-sheng commented on a change in pull request #10:
URL:
https://github.com/apache/skywalking-satellite/pull/10#discussion_r546252360
##########
File path: plugins/queue/mmap/queue_opreation.go
##########
@@ -0,0 +1,237 @@
+// Licensed to Apache Software Foundation (ASF) under one or more contributor
Review comment:
2 things,
1. `opreation` -> `operation`? Seems a typo
2. License issue, I crosscheck this with the following two files, they have
similar codes, which I think we should remove the ASF header, because we don't
own the original copyright. Le't keep its [MIT
license](https://github.com/grandecola/bigqueue/blob/master/LICENSE) in the
header part and add comments about the original sources and why we need to
change codes.
- https://github.com/grandecola/bigqueue/blob/master/write.go
- https://github.com/grandecola/bigqueue/blob/master/read.go
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
