EvanLjp commented on a change in pull request #10:
URL:
https://github.com/apache/skywalking-satellite/pull/10#discussion_r546274258
##########
File path: Makefile
##########
@@ -36,7 +37,7 @@ GO_BUILD_FLAGS = -v
GO_BUILD_LDFLAGS = -X main.version=$(VERSION)
GQL_GEN = $(GO_PATH)/bin/gqlgen
-PLATFORMS := windows linux darwin
+PLATFORMS := linux darwin
Review comment:
yes, mmap is not supported in windows , I found that there were many
mmap go lib problems
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
