tom-pytel edited a comment on pull request #20: URL: https://github.com/apache/skywalking-nodejs/pull/20#issuecomment-752936512
> > note the missing entry spans for the non-error / endpoint. > > Those are collapsed by me , only to show the full list Ok, missed that, so my only doubt remains the use of `on-finished` in HttpPlugin, you understand my concern with the potential problem there no? [NOTE]: I am not CERTAIN that `on-finished` has internal state which could be problematic, but in cases like this I usually stay on the side of simplicity and safety. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
