kezhenxu94 commented on pull request #20: URL: https://github.com/apache/skywalking-nodejs/pull/20#issuecomment-752939179
> I am worried the on-finished module used by skywalking may be different instance from what main app uses. This make sense to me now, this concern didn't show up until this bug appears. > I usually stay on the side of simplicity (not creating more dependanices) and safety. I can't agree more with the opinion, removing `on-finished` may be OK for now since we have very limited plugins that involve with `stream`, when we have more similar (involve with `stream`) plugin in the future, we may need to replicate the features of it someday, so that others don't need to "spend a good bit of time making sure the order of execution was good". Anyway, I agree to keep dependencies as simple as possible and hence I'll remove this for now ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
