tom-pytel edited a comment on pull request #20:
URL: https://github.com/apache/skywalking-nodejs/pull/20#issuecomment-752977972


   > The tests failed because of `startTime` orders, so from my gut feelings 
the `close` / `end` should be related to the `endTime`, no?
   
   Really? So did I misunderstand it? Because to me it appears it is the end 
times which were off? And yest if it really is `startTime` then that would not 
be `close` event, but you should use that one anyway.
   ```
   segmentItems:
   - serviceName: server
     segmentSize: 1
     segments:
     - segmentId: d2f08d8dfd9e442d85540f8949d9a900
       spans:
       - operationName: /test
         operationId: 0
         parentSpanId: -1
         spanId: 0
         spanLayer: Http
         startTime: 1609423678310
         endTime: 1609423678327
         componentId: 49
         isError: false
         spanType: Entry
         peer: server:5000
         skipAnalysis: false
         tags:
         - {key: http.url, value: 'server:5000/test'}
         - {key: http.status.code, value: '200'}
         refs:
         - {parentEndpoint: '', networkAddress: 'server:5000', refType: 
CrossProcess,
           parentSpanId: 1, parentTraceSegmentId: 
b7205383d91a4e94a5091aee9b711635, parentServiceInstance: 7179ea40313c,
           parentService: client, traceId: 2015765c2630485baf62a9df450d210e}
       - operationName: /json
         operationId: 0
         parentSpanId: 0
         spanId: 1
         spanLayer: Http
         startTime: 1609423678312
         endTime: 1609423678357
         componentId: 2
         isError: false
         spanType: Exit
         peer: httpbin.org
         skipAnalysis: false
         tags:
         - {key: http.url, value: httpbin.org/json}
         - {key: http.status.code, value: '200'}
         - {key: http.status.msg, value: OK}
   - serviceName: client
     segmentSize: 1
     segments:
     - segmentId: b7205383d91a4e94a5091aee9b711635
       spans:
       - operationName: /test
         operationId: 0
         parentSpanId: -1
         spanId: 0
         spanLayer: Http
         startTime: 1609423678286
         endTime: 1609423678302
         componentId: 49
         isError: false
         spanType: Entry
         peer: localhost:5001
         skipAnalysis: false
         tags:
         - {key: http.url, value: 'localhost:5001/test'}
         - {key: http.status.code, value: '200'}
       - operationName: /test
         operationId: 0
         parentSpanId: 0
         spanId: 1
         spanLayer: Http
         startTime: 1609423678288
         endTime: 1609423678351
         componentId: 2
         isError: false
         spanType: Exit
         peer: server:5000
         skipAnalysis: false
         tags:
         - {key: http.url, value: 'server:5000/test'}
         - {key: http.status.code, value: '200'}
         - {key: http.status.msg, value: OK}
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to